Fix review comments
parent
bd03cbf6db
commit
fb719a6ba6
|
|
@ -1,4 +1,5 @@
|
||||||
# usbrelay
|
# usbrelay
|
||||||
--------------------------------
|
--------------------------------
|
||||||
|
|
||||||
Description of the plugin...
|
This plugin eneblas you to control low-cost USB HID relays. The plugin creates a power device for each relay and can be controlled using the `power?? interface.
|
||||||
|
Examples of USB relay hardware can be found [here](http://vusb.wikidot.com/project:driver-less-usb-relays-hid-interface).
|
||||||
|
|
|
||||||
|
|
@ -90,7 +90,7 @@ void DevicePluginUsbRelay::deviceRemoved(Device *device)
|
||||||
UsbRelay *relay = m_relayDevices.key(device);
|
UsbRelay *relay = m_relayDevices.key(device);
|
||||||
if (!relay) return;
|
if (!relay) return;
|
||||||
m_relayDevices.remove(relay);
|
m_relayDevices.remove(relay);
|
||||||
relay->deleteLater();
|
delete relay;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
@ -189,7 +189,7 @@ void DevicePluginUsbRelay::setupDevice(DeviceSetupInfo *info)
|
||||||
UsbRelay *relay = new UsbRelay(path, relayCount, this);
|
UsbRelay *relay = new UsbRelay(path, relayCount, this);
|
||||||
m_relayDevices.insert(relay, device);
|
m_relayDevices.insert(relay, device);
|
||||||
|
|
||||||
connect(relay, &UsbRelay::connectedChanged, [this, device, relay](bool connected) {
|
connect(relay, &UsbRelay::connectedChanged, this, [this, device, relay](bool connected) {
|
||||||
qCDebug(dcUsbRelay()) << "Device" << device->name() << (connected ? "connected" : "disconnected");
|
qCDebug(dcUsbRelay()) << "Device" << device->name() << (connected ? "connected" : "disconnected");
|
||||||
device->setStateValue(usbRelayConnectorConnectedStateTypeId, connected);
|
device->setStateValue(usbRelayConnectorConnectedStateTypeId, connected);
|
||||||
|
|
||||||
|
|
@ -204,7 +204,7 @@ void DevicePluginUsbRelay::setupDevice(DeviceSetupInfo *info)
|
||||||
}
|
}
|
||||||
});
|
});
|
||||||
|
|
||||||
connect(relay, &UsbRelay::relayPowerChanged, [this, device](int relayNumber, bool power) {
|
connect(relay, &UsbRelay::relayPowerChanged, this, [this, device](int relayNumber, bool power) {
|
||||||
Device *relayDevice = getRelayDevice(device, relayNumber);
|
Device *relayDevice = getRelayDevice(device, relayNumber);
|
||||||
if (!relayDevice) {
|
if (!relayDevice) {
|
||||||
// Note: probably not set up yet
|
// Note: probably not set up yet
|
||||||
|
|
|
||||||
Loading…
Reference in New Issue