From fb719a6ba61ca38ef27b83a050112268c92ed0aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Thu, 16 Jan 2020 11:32:22 +0100 Subject: [PATCH] Fix review comments --- usbrelay/README.md | 3 ++- usbrelay/devicepluginusbrelay.cpp | 6 +++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/usbrelay/README.md b/usbrelay/README.md index 2116b91f..12cae02d 100644 --- a/usbrelay/README.md +++ b/usbrelay/README.md @@ -1,4 +1,5 @@ # usbrelay -------------------------------- -Description of the plugin... +This plugin eneblas you to control low-cost USB HID relays. The plugin creates a power device for each relay and can be controlled using the `power?? interface. +Examples of USB relay hardware can be found [here](http://vusb.wikidot.com/project:driver-less-usb-relays-hid-interface). diff --git a/usbrelay/devicepluginusbrelay.cpp b/usbrelay/devicepluginusbrelay.cpp index 1d8728bd..02bdeaf3 100644 --- a/usbrelay/devicepluginusbrelay.cpp +++ b/usbrelay/devicepluginusbrelay.cpp @@ -90,7 +90,7 @@ void DevicePluginUsbRelay::deviceRemoved(Device *device) UsbRelay *relay = m_relayDevices.key(device); if (!relay) return; m_relayDevices.remove(relay); - relay->deleteLater(); + delete relay; } } @@ -189,7 +189,7 @@ void DevicePluginUsbRelay::setupDevice(DeviceSetupInfo *info) UsbRelay *relay = new UsbRelay(path, relayCount, this); m_relayDevices.insert(relay, device); - connect(relay, &UsbRelay::connectedChanged, [this, device, relay](bool connected) { + connect(relay, &UsbRelay::connectedChanged, this, [this, device, relay](bool connected) { qCDebug(dcUsbRelay()) << "Device" << device->name() << (connected ? "connected" : "disconnected"); device->setStateValue(usbRelayConnectorConnectedStateTypeId, connected); @@ -204,7 +204,7 @@ void DevicePluginUsbRelay::setupDevice(DeviceSetupInfo *info) } }); - connect(relay, &UsbRelay::relayPowerChanged, [this, device](int relayNumber, bool power) { + connect(relay, &UsbRelay::relayPowerChanged, this, [this, device](int relayNumber, bool power) { Device *relayDevice = getRelayDevice(device, relayNumber); if (!relayDevice) { // Note: probably not set up yet