ETM-Schurig/powersync-core
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge PR #373: Fix memory off-by-one overflow

Browse Source
This commit is contained in:
Jenkins nymea 2020-12-21 18:01:04 +01:00
commit 5d6ca5a45a
2 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libnymea-core/integrations/python/pynymealogginghandler.h
View File

@ -28,8 +28,7 @@ static int PyNymeaLoggingHandler_init(PyNymeaLoggingHandler *self, PyObject *arg
return -1; return -1;
} }
self->category = (char*)malloc(qstrlen(category)); self->category = qstrdup(category);
qstrcpy(self->category, category);
return 0; return 0;
} }
@ -37,7 +36,7 @@ static int PyNymeaLoggingHandler_init(PyNymeaLoggingHandler *self, PyObject *arg
static void PyNymeaLoggingHandler_dealloc(PyNymeaLoggingHandler * self) static void PyNymeaLoggingHandler_dealloc(PyNymeaLoggingHandler * self)
{ {
qCDebug(dcPythonIntegrations()) << "--- PyNymeaLoggingHandler"; qCDebug(dcPythonIntegrations()) << "--- PyNymeaLoggingHandler";
free(self->category); delete[] self->category;
Py_TYPE(self)->tp_free(self); Py_TYPE(self)->tp_free(self);
} }

5
libnymea-core/integrations/python/pystdouthandler.h
View File

@ -30,9 +30,8 @@ static int PyStdOutHandler_init(PyStdOutHandler *self, PyObject *args, PyObject
return -1; return -1;
} }
self->category = (char*)malloc(qstrlen(category)); self->category = qstrdup(category);
self->msgType = msgType; self->msgType = msgType;
qstrcpy(self->category, category);
return 0; return 0;
} }
@ -40,7 +39,7 @@ static int PyStdOutHandler_init(PyStdOutHandler *self, PyObject *args, PyObject
static void PyStdOutHandler_dealloc(PyStdOutHandler * self) static void PyStdOutHandler_dealloc(PyStdOutHandler * self)
{ {
qCDebug(dcPythonIntegrations()) << "--- PyStdOutHandler"; qCDebug(dcPythonIntegrations()) << "--- PyStdOutHandler";
free(self->category); delete[] self->category;
Py_TYPE(self)->tp_free(self); Py_TYPE(self)->tp_free(self);
} }