Fix memory off-by-one overflow

This commit is contained in:
Michael Zanetti 2020-12-15 22:30:03 +01:00
parent 4ce5d773b0
commit 2898a08efd
2 changed files with 4 additions and 6 deletions

View File

@ -28,8 +28,7 @@ static int PyNymeaLoggingHandler_init(PyNymeaLoggingHandler *self, PyObject *arg
return -1;
}
self->category = (char*)malloc(qstrlen(category));
qstrcpy(self->category, category);
self->category = qstrdup(category);
return 0;
}
@ -37,7 +36,7 @@ static int PyNymeaLoggingHandler_init(PyNymeaLoggingHandler *self, PyObject *arg
static void PyNymeaLoggingHandler_dealloc(PyNymeaLoggingHandler * self)
{
qCDebug(dcPythonIntegrations()) << "--- PyNymeaLoggingHandler";
free(self->category);
delete[] self->category;
Py_TYPE(self)->tp_free(self);
}

View File

@ -30,9 +30,8 @@ static int PyStdOutHandler_init(PyStdOutHandler *self, PyObject *args, PyObject
return -1;
}
self->category = (char*)malloc(qstrlen(category));
self->category = qstrdup(category);
self->msgType = msgType;
qstrcpy(self->category, category);
return 0;
}
@ -40,7 +39,7 @@ static int PyStdOutHandler_init(PyStdOutHandler *self, PyObject *args, PyObject
static void PyStdOutHandler_dealloc(PyStdOutHandler * self)
{
qCDebug(dcPythonIntegrations()) << "--- PyStdOutHandler";
free(self->category);
delete[] self->category;
Py_TYPE(self)->tp_free(self);
}