Merge PR #206: HttpCommander: Build with more strict compiler settings

This commit is contained in:
Jenkins nymea 2020-01-18 23:58:22 +01:00
commit d8938bfe16

View File

@ -71,7 +71,7 @@ void DevicePluginHttpCommander::executeAction(DeviceActionInfo *info)
QString method = action.param(httpRequestRequestActionMethodParamTypeId).value().toString(); QString method = action.param(httpRequestRequestActionMethodParamTypeId).value().toString();
QByteArray payload = action.param(httpRequestRequestActionBodyParamTypeId).value().toByteArray(); QByteArray payload = action.param(httpRequestRequestActionBodyParamTypeId).value().toByteArray();
QNetworkReply *reply; QNetworkReply *reply = nullptr;
if (method == "GET") { if (method == "GET") {
reply = hardwareManager()->networkManager()->get(QNetworkRequest(url)); reply = hardwareManager()->networkManager()->get(QNetworkRequest(url));
} else if (method == "POST") { } else if (method == "POST") {
@ -80,6 +80,10 @@ void DevicePluginHttpCommander::executeAction(DeviceActionInfo *info)
reply = hardwareManager()->networkManager()->put(QNetworkRequest(url), payload); reply = hardwareManager()->networkManager()->put(QNetworkRequest(url), payload);
} else if (method == "DELETE") { } else if (method == "DELETE") {
reply = hardwareManager()->networkManager()->deleteResource(QNetworkRequest(url)); reply = hardwareManager()->networkManager()->deleteResource(QNetworkRequest(url));
} else {
qCWarning(dcHttpCommander()) << "Unsupported HTTP method" << method;
info->finish(Device::DeviceErrorInvalidParameter);
return;
} }
connect(reply, &QNetworkReply::finished, this, [device, reply, this](){ connect(reply, &QNetworkReply::finished, this, [device, reply, this](){