ETM-Schurig
/
powersync-plugins
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MQTT client: Fix a crash when failing to connect to the internal broker

master
Michael Zanetti 2022-11-18 13:19:12 +01:00
parent f111b77bc0
commit aa780ee943
2 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
mqttclient/integrationpluginmqttclient.cpp
View File

@ -50,6 +50,11 @@ void IntegrationPluginMqttClient::setupThing(ThingSetupInfo *info)
}
if (thing->thingClassId() == internalMqttClientThingClassId) {
client = hardwareManager()->mqttProvider()->createInternalClient(thing->id().toString());
if (!client) {
info->finish(Thing::ThingErrorHardwareNotAvailable, QT_TR_NOOP("Unable to to connect to internal MQTT broker. Verify the MQTT broker is set up and running."));
return;
}
} else if (thing->thingClassId() == mqttClientThingClassId){
client = new MqttClient(thing->paramValue(mqttClientThingClientIdParamTypeId).toString(), this);
client->setUsername(thing->paramValue(mqttClientThingUsernameParamTypeId).toString());

41
mqttclient/translations/27c58205-07c8-4482-85ad-b435387803a5-en_US.ts
View File

@ -1,6 +1,17 @@
<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE TS>
<TS version="2.1">
<context>
<name>IntegrationPluginMqttClient</name>
<message>
<source>Unable to to connect to internal MQTT broker. Verify the MQTT broker is set up and running.</source>
<translation type="unfinished"></translation>
</message>
<message>
<source>An error happened connecting to the MQTT broker. Please make sure the login credentials are correct and your user has apprpriate permissions to subscribe to the given topic filter.</source>
<translation type="unfinished"></translation>
</message>
</context>
<context>
<name>mqttclient</name>
<message>
@ -100,5 +111,35 @@ The name of the ParamType (ThingClass: internalMqttClient, EventType: triggered,
<extracomment>The name of the vendor ({2062d64d-3232-433c-88bc-0d33c0ba2ba6})</extracomment>
<translation type="unfinished"></translation>
</message>
<message>
<source>Client Id</source>
<extracomment>The name of the ParamType (ThingClass: mqttClient, Type: thing, ID: {621f9054-2b64-4de9-93d2-65bba96a14a3})</extracomment>
<translation type="unfinished"></translation>
</message>
<message>
<source>Retain will</source>
<extracomment>The name of the ParamType (ThingClass: mqttClient, Type: thing, ID: {c7fba1f0-a7b0-4162-8b50-fb85697fe678})</extracomment>
<translation type="unfinished"></translation>
</message>
<message>
<source>Use SSL</source>
<extracomment>The name of the ParamType (ThingClass: mqttClient, Type: thing, ID: {714074bd-1ab1-4ee6-b6db-7594b3dbf56f})</extracomment>
<translation type="unfinished"></translation>
</message>
<message>
<source>Will QoS</source>
<extracomment>The name of the ParamType (ThingClass: mqttClient, Type: thing, ID: {470b600d-e1c1-4ae7-83d4-0179600e4187})</extracomment>
<translation type="unfinished"></translation>
</message>
<message>
<source>Will message</source>
<extracomment>The name of the ParamType (ThingClass: mqttClient, Type: thing, ID: {acb19fba-d140-4ff1-b4ec-3b933c04417e})</extracomment>
<translation type="unfinished"></translation>
</message>
<message>
<source>Will topic</source>
<extracomment>The name of the ParamType (ThingClass: mqttClient, Type: thing, ID: {04aa1f25-4ee9-4bce-9844-a9860642c938})</extracomment>
<translation type="unfinished"></translation>
</message>
</context>
</TS>