ETM-Schurig/etm-powersync-plugins
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge PR #593: Keba: Finish action info after updating the according state

Browse Source
This commit is contained in:
jenkins 2022-08-25 15:06:55 +02:00
commit 9155e4ec02
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
keba/integrationpluginkeba.cpp
View File

@ -460,7 +460,6 @@ void IntegrationPluginKeba::onCommandExecuted(QUuid requestId, bool success)
ThingActionInfo *info = m_asyncActions.take(requestId); ThingActionInfo *info = m_asyncActions.take(requestId);
if (success) { if (success) {
qCDebug(dcKeba()) << "Action execution finished successfully. Request ID:" << requestId.toString(); qCDebug(dcKeba()) << "Action execution finished successfully. Request ID:" << requestId.toString();
info->finish(Thing::ThingErrorNoError);
if (thing->thingClassId() == kebaThingClassId) { if (thing->thingClassId() == kebaThingClassId) {
// Set the value to the state so we don't have to wait for the report 2 response // Set the value to the state so we don't have to wait for the report 2 response
@ -479,6 +478,8 @@ void IntegrationPluginKeba::onCommandExecuted(QUuid requestId, bool success)
info->thing()->setStateValue("power", info->action().paramValue(kebaSimplePowerActionTypeId).toBool()); info->thing()->setStateValue("power", info->action().paramValue(kebaSimplePowerActionTypeId).toBool());
} }
} }
info->finish(Thing::ThingErrorNoError);
} else { } else {
qCWarning(dcKeba()) << "Action execution finished with error. Request ID:" << requestId.toString(); qCWarning(dcKeba()) << "Action execution finished with error. Request ID:" << requestId.toString();
info->finish(Thing::ThingErrorHardwareFailure); info->finish(Thing::ThingErrorHardwareFailure);