From 3c0c4c80b3c4415f9a7ecb03c16b07856e013469 Mon Sep 17 00:00:00 2001 From: "bernhard.trinnes" Date: Thu, 9 Jul 2020 19:46:46 +0200 Subject: [PATCH] fixed remarks from review --- solarlog/integrationpluginsolarlog.cpp | 4 ++-- solarlog/integrationpluginsolarlog.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/solarlog/integrationpluginsolarlog.cpp b/solarlog/integrationpluginsolarlog.cpp index 893be36a..6d4ea867 100644 --- a/solarlog/integrationpluginsolarlog.cpp +++ b/solarlog/integrationpluginsolarlog.cpp @@ -90,7 +90,7 @@ void IntegrationPluginSolarLog::getData(Thing *thing) request.setHeader(QNetworkRequest::KnownHeaders::ContentTypeHeader, "application/json"); QNetworkReply *reply = hardwareManager()->networkManager()->post(request, QByteArray("{\"801\":{\"170\":null}}")); connect(reply, &QNetworkReply::finished, reply, &QNetworkReply::deleteLater); - connect(reply, &QNetworkReply::finished, this, [this, reply, thing]{ + connect(reply, &QNetworkReply::finished, thing, [this, reply, thing]{ int status = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt(); @@ -110,7 +110,7 @@ void IntegrationPluginSolarLog::getData(Thing *thing) QJsonParseError error; QJsonDocument data = QJsonDocument::fromJson(rawData, &error); if (error.error != QJsonParseError::NoError) { - qCWarning(dcSolarlog()) << "Received invalide JSON object, try to upgrade the Solarlog firmware. Min Version is 3.5."; + qCWarning(dcSolarlog()) << "Received invalid JSON object, try to upgrade the Solarlog firmware. Min Version is 3.5."; if (m_asyncSetup.contains(thing)) { ThingSetupInfo *info = m_asyncSetup.take(thing); info->finish(Thing::ThingErrorHardwareFailure, tr("Outdated Solar-Log firmware")); diff --git a/solarlog/integrationpluginsolarlog.json b/solarlog/integrationpluginsolarlog.json index 7e3df450..0836287b 100644 --- a/solarlog/integrationpluginsolarlog.json +++ b/solarlog/integrationpluginsolarlog.json @@ -21,7 +21,7 @@ "displayName": "Address", "type": "QString", "inputType": "TextLine", - "defaultValue": "http://solar-log" + "defaultValue": "solar-log" } ], "stateTypes": [