changes requested by reviewer

master
bernhard.trinnes 2020-03-23 14:36:22 +01:00
parent e9b9166e65
commit 311774f326
3 changed files with 6 additions and 6 deletions

View File

@ -12,10 +12,12 @@ This plugin integrates DoorBird video doorbells into nymea. All the communicatio
* Switching door relays * Switching door relays
* No internet connection required * No internet connection required
NOTE: This plug-in does not handle any video- or audio stream.
## Requirements ## Requirements
* The DoorBird device must be in the same local area network as nymea. * The DoorBird device must be in the same local area network as nymea.
* The router must not block avahi/zeroconf multicast messages. * The router must not block ZeroConf/mDNS multicast messages.
* TCP Sockets on port 80 must not be blocked by the router. * TCP Sockets on port 80 must not be blocked by the router.
* The user must have the permission to act as DoorBird API-operator. * The user must have the permission to act as DoorBird API-operator.
* You can check the permissions in the DoorBird app. * You can check the permissions in the DoorBird app.
@ -23,4 +25,4 @@ This plugin integrates DoorBird video doorbells into nymea. All the communicatio
## More ## More
https://www.doorbird.com/ https://www.doorbird.com

View File

@ -2,8 +2,6 @@ include(../plugins.pri)
QT += network QT += network
TARGET = $$qtLibraryTarget(nymea_integrationplugindoorbird)
SOURCES += \ SOURCES += \
integrationplugindoorbird.cpp \ integrationplugindoorbird.cpp \
doorbird.cpp \ doorbird.cpp \

View File

@ -85,7 +85,7 @@ void IntegrationPluginDoorbird::discoverThings(ThingDiscoveryInfo *info)
return; return;
} else { } else {
qCWarning(dcDoorBird()) << "Cannot discover for ThingClassId" << info->thingClassId(); qCWarning(dcDoorBird()) << "Cannot discover for ThingClassId" << info->thingClassId();
info->finish(Thing::ThingErrorThingNotFound); info->finish(Thing::ThingErrorThingClassNotFound);
} }
} }
@ -97,7 +97,7 @@ void IntegrationPluginDoorbird::startPairing(ThingPairingInfo *info)
return; return;
} else { } else {
qCWarning(dcDoorBird()) << "StartPairing unhandled ThingClassId" << info->thingClassId(); qCWarning(dcDoorBird()) << "StartPairing unhandled ThingClassId" << info->thingClassId();
info->finish(Thing::ThingErrorCreationMethodNotSupported); info->finish(Thing::ThingErrorThingClassNotFound);
} }
} }