From fbcb7a7fa9c3fdf4631bad70bdab33a9abfa10a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Mon, 18 Aug 2025 16:00:55 +0200 Subject: [PATCH] Fix type change and comparison of valueCount() in different Qt versions --- nymea-modbus-cli/main.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nymea-modbus-cli/main.cpp b/nymea-modbus-cli/main.cpp index caa4e0f..3a0aa77 100644 --- a/nymea-modbus-cli/main.cpp +++ b/nymea-modbus-cli/main.cpp @@ -366,7 +366,8 @@ void sendRequest(quint16 modbusServerAddress, QModbusDataUnit::RegisterType regi } const QModbusDataUnit unit = reply->result(); - for (uint i = 0; i < unit.valueCount(); i++) { + // Note: we need the cast in since the valueCount() type changes with different Qt versions + for (int i = 0; i < static_cast(unit.valueCount()); i++) { quint16 registerValue = unit.values().at(i); quint16 registerNumber = unit.startAddress() + i; qInfo() << "-->" << registerNumber << ":" << QString("0x%1").arg(registerValue, 4, 16, QLatin1Char('0')) << registerValue; @@ -416,7 +417,8 @@ void sendRequest(quint16 modbusServerAddress, QModbusDataUnit::RegisterType regi } const QModbusDataUnit unit = reply->result(); - for (uint i = 0; i < unit.valueCount(); i++) { + // Note: we need the cast in since the valueCount() type changes with different Qt versions + for (int i = 0; i < static_cast(unit.valueCount()); i++) { quint16 registerValue = unit.values().at(i); quint16 registerNumber = unit.startAddress() + i; qInfo() << "-->" << registerNumber << ":" << QString("0x%1").arg(registerValue, 4, 16, QLatin1Char('0')) << registerValue;