ETM-Schurig/powersync-plugins-modbus
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix response values validation

Browse Source
This commit is contained in:
Simon Stürz 2022-08-10 10:22:07 +02:00
parent afaaa04d62
commit f704e84ffd
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
huawei/huaweifusionsolar.cpp
View File

@ -593,17 +593,17 @@ bool HuaweiFusionSolar::valuesAreVaild(const QVector<quint16> &values, int readS
return false; return false;
} }
// According to the documentation: // According to the documentation from 2016:
// 0x7FFF: invalid value of the floating point type returned by one register // 0x7FFF: invalid value of the floating point type returned by one register
// 0xFFFF: invalid value of a type other than the floating point type returned by one register // 0xFFFF: invalid value of a type other than the floating point type returned by one register
// 0xFFFFFFFF: invalid value returned by two registers // 0xFFFFFFFF: invalid value returned by two registers
if (values.count() == 2) { if (values.count() == 2) {
bool floatingPointValid = (values.at(0) != 0x7fff && values.at(1) != 0xffff); bool floatingPointValid = (values != QVector<quint16>() << 0x7fff << 0xffff);
if (!floatingPointValid) if (!floatingPointValid)
qCDebug(dcHuaweiFusionSolar()) << "Invalid values. The received values match the invalid for floating pointer:" << values; qCDebug(dcHuaweiFusionSolar()) << "Invalid values. The received values match the invalid for floating pointer:" << values;
bool otherTypesValid = (values.at(0) != 0xffff && values.at(1) != 0xffff); bool otherTypesValid = (values != QVector<quint16>(2, 0xffff));
if (!otherTypesValid) if (!otherTypesValid)
qCDebug(dcHuaweiFusionSolar()) << "Invalid values. The received values match the invalid registers values:" << values; qCDebug(dcHuaweiFusionSolar()) << "Invalid values. The received values match the invalid registers values:" << values;