ETM-Schurig/powersync-core
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a python plugin crash when trying to login with empty credentials

Browse Source
This commit is contained in:
Michael Zanetti 2022-08-07 12:29:48 +02:00
parent 5674ba7567
commit fc8c9df40e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libnymea-core/integrations/pythonintegrationplugin.cpp
View File

@ -505,8 +505,9 @@ void PythonIntegrationPlugin::confirmPairing(ThingPairingInfo *info, const QStri
PyEval_ReleaseThread(m_threadState); PyEval_ReleaseThread(m_threadState);
}); });
PyObject *pyUsername = PyUnicode_FromString(username.toUtf8().data()); // PyUnicode_FromString crashes on empty strings. Creating a new empty python string instead.
PyObject *pySecret = PyUnicode_FromString(secret.toUtf8().data()); PyObject *pyUsername = username.isEmpty() ? PyUnicode_New(1, 127) : PyUnicode_FromString(username.toUtf8().data());
PyObject *pySecret = secret.isEmpty() ? PyUnicode_New(1, 127) : PyUnicode_FromString(secret.toUtf8().data());
bool result = callPluginFunction("confirmPairing", reinterpret_cast<PyObject*>(pyInfo), pyUsername, pySecret); bool result = callPluginFunction("confirmPairing", reinterpret_cast<PyObject*>(pyInfo), pyUsername, pySecret);
if (!result) { if (!result) {
info->finish(Thing::ThingErrorHardwareFailure, "Plugin error: " + pluginName()); info->finish(Thing::ThingErrorHardwareFailure, "Plugin error: " + pluginName());