From ecbf4e345a906df12b9da90c1244812106040643 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Thu, 28 May 2015 22:22:36 +0200 Subject: [PATCH] fix hue memory leak --- plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp | 2 +- plugins/deviceplugins/philipshue/huebridgeconnection.cpp | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp b/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp index 5afc2644..32652cfa 100644 --- a/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp +++ b/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp @@ -158,7 +158,7 @@ void DevicePluginPhilipsHue::deviceRemoved(Device *device) Light *light = m_lights.key(device); m_lights.remove(light); - m_unconfiguredLights.append(light); + light->deleteLater(); } void DevicePluginPhilipsHue::upnpDiscoveryFinished(const QList &upnpDeviceDescriptorList) diff --git a/plugins/deviceplugins/philipshue/huebridgeconnection.cpp b/plugins/deviceplugins/philipshue/huebridgeconnection.cpp index 79b086ea..a070233b 100644 --- a/plugins/deviceplugins/philipshue/huebridgeconnection.cpp +++ b/plugins/deviceplugins/philipshue/huebridgeconnection.cpp @@ -96,6 +96,8 @@ void HueBridgeConnection::slotCreateUserFinished() QByteArray data = reply->readAll(); int id = m_createUserMap.take(reply); + reply->deleteLater(); + QJsonParseError error; QJsonDocument jsonDoc = QJsonDocument::fromJson(data, &error); @@ -120,6 +122,8 @@ void HueBridgeConnection::slotGetFinished() QByteArray data = reply->readAll(); Caller c = m_requestMap.take(reply); + reply->deleteLater(); + QJsonParseError error; QJsonDocument jsonDoc = QJsonDocument::fromJson(data, &error);