From 76cc3577e142a5421397b4d68037fffe85dbb69b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Simon=20St=C3=BCrz?= <stuerz.simon@gmail.com>
Date: Fri, 1 Apr 2016 21:03:55 +0200
Subject: [PATCH] improve ruleengine test coverage

---
 tests/auto/rules/testrules.cpp | 37 +++++++++++++++++++++++++++++-----
 1 file changed, 32 insertions(+), 5 deletions(-)

diff --git a/tests/auto/rules/testrules.cpp b/tests/auto/rules/testrules.cpp
index 2fb2e8ba..942c5b86 100644
--- a/tests/auto/rules/testrules.cpp
+++ b/tests/auto/rules/testrules.cpp
@@ -816,9 +816,15 @@ void TestRules::executeRuleActions()
     cleanupMockHistory();
     QTest::qWait(200);
 
+    // EEXCUTE action invalid ruleId
+    QVariantMap executeParams;
+    executeParams.insert("ruleId", QUuid::createUuid().toString());
+    response = injectAndWait("Rules.ExecuteActions", executeParams);
+    verifyRuleError(response, RuleEngine::RuleErrorRuleNotFound);
+
     // EXECUTE actions
     qDebug() << "Execute rule actions";
-    QVariantMap executeParams;
+    executeParams.clear();
     executeParams.insert("ruleId", ruleId.toString());
     response = injectAndWait("Rules.ExecuteActions", executeParams);
     verifyRuleError(response, ruleError);
@@ -835,8 +841,16 @@ void TestRules::executeRuleActions()
     cleanupMockHistory();
     QTest::qWait(200);
 
+    // EXECUTE exit actions invalid ruleId
+    executeParams.clear();
+    executeParams.insert("ruleId", QUuid::createUuid().toString());
+    response = injectAndWait("Rules.ExecuteExitActions", executeParams);
+    verifyRuleError(response, RuleEngine::RuleErrorRuleNotFound);
+
     // EXECUTE exit actions
     qDebug() << "Execute rule exit actions";
+    executeParams.clear();
+    executeParams.insert("ruleId", ruleId.toString());
     response = injectAndWait("Rules.ExecuteExitActions", executeParams);
     verifyRuleError(response, ruleError);
 
@@ -1450,8 +1464,14 @@ void TestRules::enableDisableRule()
 
     cleanupMockHistory();
 
-    // Now disable the rule
+    // Now DISABLE the rule invalid ruleId
     QVariantMap disableParams;
+    disableParams.insert("ruleId", QUuid::createUuid().toString());
+    response = injectAndWait("Rules.DisableRule", disableParams);
+    verifyRuleError(response, RuleEngine::RuleErrorRuleNotFound);
+
+    // Now DISABLE the rule
+    disableParams.clear();
     disableParams.insert("ruleId", id.toString());
     response = injectAndWait("Rules.DisableRule", disableParams);
     verifyRuleError(response);
@@ -1469,10 +1489,17 @@ void TestRules::enableDisableRule()
 
     cleanupMockHistory();
 
-    // Now enable the rule again
-    response = injectAndWait("Rules.EnableRule", disableParams);
-    verifyRuleError(response);
+    // Now ENABLE the rule again invald ruleId
+    QVariantMap enableParams;
+    enableParams.insert("ruleId", QUuid::createUuid().toString());
+    response = injectAndWait("Rules.EnableRule", enableParams);
+    verifyRuleError(response, RuleEngine::RuleErrorRuleNotFound);
 
+    // Now ENABLE the rule again
+    enableParams.clear();
+    enableParams.insert("ruleId", id.toString());
+    response = injectAndWait("Rules.EnableRule", enableParams);
+    verifyRuleError(response);
 
     // trigger event in mock device
     spy.clear();