diff --git a/libguh/devicemanager.cpp b/libguh/devicemanager.cpp index 83e157de..734e6759 100644 --- a/libguh/devicemanager.cpp +++ b/libguh/devicemanager.cpp @@ -131,7 +131,7 @@ DevicePlugin *DeviceManager::plugin(const PluginId &id) const return m_devicePlugins.value(id); } -QPair DeviceManager::setPluginConfig(const PluginId &pluginId, const QList &pluginConfig) +QPair DeviceManager::setPluginConfig(const PluginId &pluginId, const ParamList &pluginConfig) { DevicePlugin *plugin = m_devicePlugins.value(pluginId); if (!plugin) { @@ -246,7 +246,7 @@ QPair DeviceManager::addConfiguredDevice(co return addConfiguredDeviceInternal(deviceClassId, descriptor.params(), deviceId); } -QPair DeviceManager::pairDevice(const DeviceClassId &deviceClassId, const QList ¶ms) +QPair DeviceManager::pairDevice(const DeviceClassId &deviceClassId, const ParamList ¶ms) { DeviceClass deviceClass = findDeviceClass(deviceClassId); if (deviceClass.id().isNull()) { @@ -260,7 +260,7 @@ QPair DeviceManager::pairDevice(const Devic } QUuid pairingTransactionId = QUuid::createUuid(); - m_pairingsJustAdd.insert(pairingTransactionId, qMakePair >(deviceClassId, params)); + m_pairingsJustAdd.insert(pairingTransactionId, qMakePair(deviceClassId, params)); if (deviceClass.setupMethod() == DeviceClass::SetupMethodDisplayPin) { // TODO: fetch PIN from device plugin @@ -524,7 +524,7 @@ void DeviceManager::loadPlugins() } QSettings settings(m_settingsFile); settings.beginGroup("PluginConfig"); - QList params; + ParamList params; if (settings.childGroups().contains(pluginIface->pluginId().toString())) { settings.beginGroup(pluginIface->pluginId().toString()); foreach (const QString ¶mName, settings.allKeys()) { @@ -566,7 +566,7 @@ void DeviceManager::loadConfiguredDevices() Device *device = new Device(PluginId(settings.value("pluginid").toString()), DeviceId(idString), DeviceClassId(settings.value("deviceClassId").toString()), this); device->setName(settings.value("devicename").toString()); - QList params; + ParamList params; settings.beginGroup("Params"); foreach (QString paramNameString, settings.allKeys()) { Param param(paramNameString); @@ -689,11 +689,11 @@ void DeviceManager::slotPairingFinished(const QUuid &pairingTransactionId, Devic } DeviceClassId deviceClassId; - QList params; + ParamList params; // Do this before checking status to make sure we clean up our hashes properly if (m_pairingsJustAdd.contains(pairingTransactionId)) { - QPair > pair = m_pairingsJustAdd.take(pairingTransactionId); + QPair pair = m_pairingsJustAdd.take(pairingTransactionId); deviceClassId = pair.first; params = pair.second; } @@ -800,7 +800,7 @@ void DeviceManager::slotDeviceStateValueChanged(const QUuid &stateTypeId, const emit deviceStateChanged(device, stateTypeId, value); Param valueParam("value", value); - Event event(EventTypeId(stateTypeId.toString()), device->id(), QList() << valueParam); + Event event(EventTypeId(stateTypeId.toString()), device->id(), ParamList() << valueParam); emit eventTriggered(event); } diff --git a/libguh/devicemanager.h b/libguh/devicemanager.h index bba5ea98..868b2183 100644 --- a/libguh/devicemanager.h +++ b/libguh/devicemanager.h @@ -74,7 +74,7 @@ public: QList plugins() const; DevicePlugin* plugin(const PluginId &id) const; - QPair setPluginConfig(const PluginId &pluginId, const QList &pluginConfig); + QPair setPluginConfig(const PluginId &pluginId, const ParamList &pluginConfig); QList supportedVendors() const; QList supportedDevices(const VendorId &vendorId = VendorId()) const; @@ -83,7 +83,7 @@ public: QList configuredDevices() const; QPair addConfiguredDevice(const DeviceClassId &deviceClassId, const ParamList ¶ms, const DeviceId id = DeviceId::createDeviceId()); QPair addConfiguredDevice(const DeviceClassId &deviceClassId, const DeviceDescriptorId &deviceDescriptorId, const DeviceId &id = DeviceId::createDeviceId()); - QPair pairDevice(const DeviceClassId &deviceClassId, const QList ¶ms); + QPair pairDevice(const DeviceClassId &deviceClassId, const ParamList ¶ms); QPair pairDevice(const DeviceClassId &deviceClassId, const DeviceDescriptorId &deviceDescriptorId); QPair confirmPairing(const QUuid &pairingTransactionId, const QString &secret = QString()); QPair removeConfiguredDevice(const DeviceId &deviceId); @@ -146,7 +146,7 @@ private: QTimer m_pluginTimer; QList m_pluginTimerUsers; - QHash > > m_pairingsJustAdd; + QHash > m_pairingsJustAdd; QHash > m_pairingsDiscovery; friend class DevicePlugin; diff --git a/libguh/plugin/device.cpp b/libguh/plugin/device.cpp index 08b746e3..2ed467f0 100644 --- a/libguh/plugin/device.cpp +++ b/libguh/plugin/device.cpp @@ -90,13 +90,13 @@ void Device::setName(const QString &name) } /*! Returns the parameter of this Device. It must match the parameter description in the associated \l{DeviceClass}. */ -QList Device::params() const +ParamList Device::params() const { return m_params; } /*! Sets the \a params of this Device. It must match the parameter description in the associated \l{DeviceClass}. */ -void Device::setParams(const QList ¶ms) +void Device::setParams(const ParamList ¶ms) { m_params = params; } @@ -113,7 +113,7 @@ QVariant Device::paramValue(const QString ¶mName) const void Device::setParamValue(const QString ¶mName, const QVariant &value) { - QList params; + ParamList params; foreach (Param param, m_params) { if (param.name() == paramName) { param.setValue(value); diff --git a/libguh/plugin/device.h b/libguh/plugin/device.h index 0b79679d..e55af536 100644 --- a/libguh/plugin/device.h +++ b/libguh/plugin/device.h @@ -44,9 +44,9 @@ public: QString name() const; void setName(const QString &name); - QList params() const; + ParamList params() const; bool hasParam(const QString ¶mName) const; - void setParams(const QList ¶ms); + void setParams(const ParamList ¶ms); QVariant paramValue(const QString ¶mName) const; void setParamValue(const QString ¶mName, const QVariant &value); @@ -76,7 +76,7 @@ private: DeviceClassId m_deviceClassId; PluginId m_pluginId; QString m_name; - QList m_params; + ParamList m_params; QList m_states; bool m_setupComplete; }; diff --git a/libguh/plugin/deviceplugin.cpp b/libguh/plugin/deviceplugin.cpp index 7d059946..b8f6a78a 100644 --- a/libguh/plugin/deviceplugin.cpp +++ b/libguh/plugin/deviceplugin.cpp @@ -172,7 +172,7 @@ void DevicePlugin::deviceRemoved(Device *device) Q_UNUSED(device) } -QPair DevicePlugin::confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const QList ¶ms) +QPair DevicePlugin::confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const ParamList ¶ms) { Q_UNUSED(pairingTransactionId) Q_UNUSED(deviceClassId) @@ -199,7 +199,7 @@ void DevicePlugin::initPlugin(DeviceManager *deviceManager) When implementing a new plugin, override this and fill in the empty configuration if your plugin requires any. */ -QList DevicePlugin::configuration() const +ParamList DevicePlugin::configuration() const { return m_config; } @@ -223,7 +223,7 @@ QVariant DevicePlugin::configValue(const QString ¶mName) const /*! Will be called by the DeviceManager to set a plugin's \a configuration. */ -QPair DevicePlugin::setConfiguration(const QList &configuration) +QPair DevicePlugin::setConfiguration(const ParamList &configuration) { foreach (const Param ¶m, configuration) { qDebug() << "setting config" << param; @@ -311,7 +311,7 @@ QList DevicePlugin::myDevices() const Find a certain device from myDevices() by its params. All parameters must match or the device will not be found. Be prepared for nullptrs. */ -Device *DevicePlugin::findDeviceByParams(const QList ¶ms) const +Device *DevicePlugin::findDeviceByParams(const ParamList ¶ms) const { foreach (Device *device, myDevices()) { bool matching = true; diff --git a/libguh/plugin/deviceplugin.h b/libguh/plugin/deviceplugin.h index e3bac96a..86b17319 100644 --- a/libguh/plugin/deviceplugin.h +++ b/libguh/plugin/deviceplugin.h @@ -55,7 +55,7 @@ public: virtual QPair setupDevice(Device *device); virtual void deviceRemoved(Device *device); - virtual QPair confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const QList ¶ms); + virtual QPair confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const ParamList ¶ms); // Hardware input virtual void radioData(QList rawData) {Q_UNUSED(rawData)} @@ -63,8 +63,8 @@ public: // Configuration virtual QList configurationDescription() const; - QPair setConfiguration(const QList &configuration); - QList configuration() const; + QPair setConfiguration(const ParamList &configuration); + ParamList configuration() const; QVariant configValue(const QString ¶mName) const; QPair setConfigValue(const QString ¶mName, const QVariant &value); @@ -86,7 +86,7 @@ signals: protected: DeviceManager *deviceManager() const; QList myDevices() const; - Device* findDeviceByParams(const QList ¶ms) const; + Device* findDeviceByParams(const ParamList ¶ms) const; void transmitData(QList rawData); @@ -97,7 +97,7 @@ private: DeviceManager *m_deviceManager; - QList m_config; + ParamList m_config; friend class DeviceManager; }; diff --git a/libguh/types/event.cpp b/libguh/types/event.cpp index c8e55441..62425b16 100644 --- a/libguh/types/event.cpp +++ b/libguh/types/event.cpp @@ -42,7 +42,7 @@ Event::Event(): /*! Constructs a Event reflecting the \l{Event} given by \a EventTypeId, associated with the \l{Device} given by \a deviceId and the parameters given by \a params. The parameters must match the description in the reflecting \l{Event}.*/ -Event::Event(const EventTypeId &eventTypeId, const DeviceId &deviceId, const QList ¶ms): +Event::Event(const EventTypeId &eventTypeId, const DeviceId &deviceId, const ParamList ¶ms): m_id(EventId::createEventId()), m_eventTypeId(eventTypeId), m_deviceId(deviceId), @@ -82,13 +82,13 @@ void Event::setDeviceId(const DeviceId &deviceId) } /*! Returns the parameters of this Event.*/ -QList Event::params() const +ParamList Event::params() const { return m_params; } /*! Set the parameters of this Event to \a params.*/ -void Event::setParams(const QList ¶ms) +void Event::setParams(const ParamList ¶ms) { m_params = params; } diff --git a/libguh/types/event.h b/libguh/types/event.h index 2d0a2dd1..d0ca8f36 100644 --- a/libguh/types/event.h +++ b/libguh/types/event.h @@ -30,7 +30,7 @@ class Event { public: Event(); - Event(const EventTypeId &eventTypeId, const DeviceId &deviceId, const QList ¶ms = QList()); + Event(const EventTypeId &eventTypeId, const DeviceId &deviceId, const ParamList ¶ms = ParamList()); EventId eventId() const; @@ -40,8 +40,8 @@ public: DeviceId deviceId() const; void setDeviceId(const DeviceId &deviceId); - QList params() const; - void setParams(const QList ¶ms); + ParamList params() const; + void setParams(const ParamList ¶ms); Param param(const QString ¶mName) const; bool operator ==(const Event &other) const; @@ -50,7 +50,7 @@ private: EventId m_id; EventTypeId m_eventTypeId; DeviceId m_deviceId; - QList m_params; + ParamList m_params; }; Q_DECLARE_METATYPE(Event) QDebug operator<<(QDebug dbg, const Event &event); diff --git a/libguh/types/param.cpp b/libguh/types/param.cpp index d4d472fe..a6193172 100644 --- a/libguh/types/param.cpp +++ b/libguh/types/param.cpp @@ -58,7 +58,7 @@ QDebug operator<<(QDebug dbg, const Param ¶m) return dbg.space(); } -QDebug operator<<(QDebug dbg, const QList ¶ms) +QDebug operator<<(QDebug dbg, const ParamList ¶ms) { dbg.nospace() << "ParamList (count:" << params.count() << ")" << endl; for (int i = 0; i < params.count(); i++ ) { @@ -98,3 +98,9 @@ void ParamList::setParamValue(const QString ¶mName, const QVariant &value) } } } + +ParamList ParamList::operator<<(const Param ¶m) +{ + this->append(param); + return *this; +} diff --git a/libguh/types/param.h b/libguh/types/param.h index 37f1d542..cef17eb2 100644 --- a/libguh/types/param.h +++ b/libguh/types/param.h @@ -42,7 +42,6 @@ private: Q_DECLARE_METATYPE(Param) QDebug operator<<(QDebug dbg, const Param ¶m); -QDebug operator<<(QDebug dbg, const QList ¶ms); class ParamList: public QList { @@ -50,6 +49,8 @@ public: bool hasParam(const QString ¶mName) const; QVariant paramValue(const QString ¶mName) const; void setParamValue(const QString ¶mName, const QVariant &value); + ParamList operator<<(const Param ¶m); }; +QDebug operator<<(QDebug dbg, const ParamList ¶ms); #endif // PARAM_H diff --git a/plugins/deviceplugins/boblight/devicepluginboblight.cpp b/plugins/deviceplugins/boblight/devicepluginboblight.cpp index 02de49f3..c42fc37e 100644 --- a/plugins/deviceplugins/boblight/devicepluginboblight.cpp +++ b/plugins/deviceplugins/boblight/devicepluginboblight.cpp @@ -100,7 +100,7 @@ void DevicePluginBoblight::startMonitoringAutoDevices() QList deviceDescriptorList; for (int i = loadedDevices.count(); i < m_bobClient->lightsCount(); i++) { DeviceDescriptor deviceDescriptor(boblightDeviceClassId, "Boblight Channel " + QString::number(i)); - QList params; + ParamList params; Param param("channel"); param.setValue(i); params.append(param); diff --git a/plugins/deviceplugins/boblight/devicepluginboblight.h b/plugins/deviceplugins/boblight/devicepluginboblight.h index 3025e9fb..cc6bae72 100644 --- a/plugins/deviceplugins/boblight/devicepluginboblight.h +++ b/plugins/deviceplugins/boblight/devicepluginboblight.h @@ -55,7 +55,6 @@ private slots: private: BobClient *m_bobClient; - QList m_config; }; #endif // DEVICEPLUGINBOBLIGHT_H diff --git a/plugins/deviceplugins/elro/devicepluginelro.cpp b/plugins/deviceplugins/elro/devicepluginelro.cpp index 3b5fa73b..de4c5e4d 100644 --- a/plugins/deviceplugins/elro/devicepluginelro.cpp +++ b/plugins/deviceplugins/elro/devicepluginelro.cpp @@ -428,7 +428,7 @@ void DevicePluginElro::radioData(QList rawData) return; } - QList params; + ParamList params; Param powerParam("power", power); params.append(powerParam); diff --git a/plugins/deviceplugins/intertechno/devicepluginintertechno.cpp b/plugins/deviceplugins/intertechno/devicepluginintertechno.cpp index 21dad455..ca80ddaa 100644 --- a/plugins/deviceplugins/intertechno/devicepluginintertechno.cpp +++ b/plugins/deviceplugins/intertechno/devicepluginintertechno.cpp @@ -686,7 +686,7 @@ void DevicePluginIntertechno::radioData(QList rawData) return; } - QList params; + ParamList params; Param powerParam("power", power); params.append(powerParam); diff --git a/plugins/deviceplugins/lircd/devicepluginlircd.cpp b/plugins/deviceplugins/lircd/devicepluginlircd.cpp index 2a6399d3..4f449a37 100644 --- a/plugins/deviceplugins/lircd/devicepluginlircd.cpp +++ b/plugins/deviceplugins/lircd/devicepluginlircd.cpp @@ -129,7 +129,7 @@ void DevicePluginLircd::buttonPressed(const QString &remoteName, const QString & qDebug() << "found remote" << remoteName << supportedDevices().first().eventTypes().count(); foreach (const EventType &eventType, supportedDevices().first().eventTypes()) { if (eventType.name() == buttonName) { - QList params; + ParamList params; Param param("repeat", repeat); params.append(param); Event event(eventType.id(), remote->id(), params); diff --git a/plugins/deviceplugins/mock/devicepluginmock.h b/plugins/deviceplugins/mock/devicepluginmock.h index ac35be73..20b3b11e 100644 --- a/plugins/deviceplugins/mock/devicepluginmock.h +++ b/plugins/deviceplugins/mock/devicepluginmock.h @@ -62,7 +62,6 @@ private slots: void emitActionExecuted(); private: - QList m_config; QHash m_daemons; QList m_asyncSetupDevices; QList > m_asyncActions; diff --git a/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp b/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp index b8813fc2..cb8f2c9a 100644 --- a/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp +++ b/plugins/deviceplugins/philipshue/devicepluginphilipshue.cpp @@ -239,7 +239,7 @@ QPair DevicePluginPhilipsHue::setupDe return reportDeviceSetup(DeviceManager::DeviceSetupStatusAsync); } -QPair DevicePluginPhilipsHue::confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const QList ¶ms) +QPair DevicePluginPhilipsHue::confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const ParamList ¶ms) { Param ipParam; foreach (const Param ¶m, params) { diff --git a/plugins/deviceplugins/philipshue/devicepluginphilipshue.h b/plugins/deviceplugins/philipshue/devicepluginphilipshue.h index 4da91943..ca9db2b4 100644 --- a/plugins/deviceplugins/philipshue/devicepluginphilipshue.h +++ b/plugins/deviceplugins/philipshue/devicepluginphilipshue.h @@ -50,7 +50,7 @@ public: QPair setupDevice(Device *device) override; - QPair confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const QList ¶ms) override; + QPair confirmPairing(const QUuid &pairingTransactionId, const DeviceClassId &deviceClassId, const ParamList ¶ms) override; void guhTimer() override; @@ -67,7 +67,6 @@ private slots: void lightStateChanged(); private: - QList m_config; Discovery *m_discovery; class PairingInfo { diff --git a/server/guhcore.cpp b/server/guhcore.cpp index 5b168c8b..a6e8c761 100644 --- a/server/guhcore.cpp +++ b/server/guhcore.cpp @@ -63,7 +63,7 @@ QList GuhCore::plugins() const return m_deviceManager->plugins(); } -QPair GuhCore::setPluginConfig(const PluginId &pluginId, const QList params) +QPair GuhCore::setPluginConfig(const PluginId &pluginId, const ParamList ¶ms) { return m_deviceManager->setPluginConfig(pluginId, params); } @@ -117,7 +117,7 @@ QPair GuhCore::pairDevice(const DeviceClass return m_deviceManager->pairDevice(deviceClassId, deviceDescriptorId); } -QPair GuhCore::pairDevice(const DeviceClassId &deviceClassId, const QList ¶ms) +QPair GuhCore::pairDevice(const DeviceClassId &deviceClassId, const ParamList ¶ms) { return m_deviceManager->pairDevice(deviceClassId, params); } diff --git a/server/guhcore.h b/server/guhcore.h index a4433ed3..cb96eb42 100644 --- a/server/guhcore.h +++ b/server/guhcore.h @@ -43,7 +43,7 @@ public: void destroy(); QList plugins() const; - QPair setPluginConfig(const PluginId &pluginId, const QList params); + QPair setPluginConfig(const PluginId &pluginId, const ParamList ¶ms); // Device handling QList supportedVendors() const; @@ -58,7 +58,7 @@ public: QPair removeConfiguredDevice(const DeviceId &deviceId, const QHash &removePolicyList); QPair pairDevice(const DeviceClassId &deviceClassId, const DeviceDescriptorId &deviceDescriptorId); - QPair pairDevice(const DeviceClassId &deviceClassId, const QList ¶ms); + QPair pairDevice(const DeviceClassId &deviceClassId, const ParamList ¶ms); QPair confirmPairing(const QUuid &pairingTransactionId, const QString &secret = QString()); QPair executeAction(const Action &action); diff --git a/server/jsonrpc/jsontypes.cpp b/server/jsonrpc/jsontypes.cpp index 589bcc8e..887252e8 100644 --- a/server/jsonrpc/jsontypes.cpp +++ b/server/jsonrpc/jsontypes.cpp @@ -448,7 +448,7 @@ ParamList JsonTypes::unpackParams(const QVariantList ¶mList) { ParamList params; foreach (const QVariant ¶mVariant, paramList) { - qDebug() << "unpacking param" << paramVariant; +// qDebug() << "unpacking param" << paramVariant; params.append(unpackParam(paramVariant.toMap())); } return params; diff --git a/tests/auto/events/testevents.cpp b/tests/auto/events/testevents.cpp index 01237bde..6ae1544f 100644 --- a/tests/auto/events/testevents.cpp +++ b/tests/auto/events/testevents.cpp @@ -98,7 +98,7 @@ void TestEvents::triggerStateChangeEvent() void TestEvents::params() { Event event; - QList params; + ParamList params; Param p("foo", "bar"); params.append(p); event.setParams(params);