From 29ee1b48f075eef42de2c6ed4559a06c676b5e9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Fri, 22 Oct 2021 12:06:20 +0200 Subject: [PATCH 1/3] Add minimal charging current to electricvehicle interface --- libnymea/interfaces/electricvehicle.json | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libnymea/interfaces/electricvehicle.json b/libnymea/interfaces/electricvehicle.json index 5ccafef3..d5cbcaa6 100644 --- a/libnymea/interfaces/electricvehicle.json +++ b/libnymea/interfaces/electricvehicle.json @@ -1,11 +1,18 @@ { - "description": "Interface for electric vehicles", + "description": "Interface for electric vehicles. Some electric cars require a minimal charging current, otherwise they don't start charging. Default is a minimum of 6 ampere.", "extends": ["battery"], "states": [ { "name": "capacity", "type": "double", "unit": "KiloWattHour" + }, + { + "name": "minimalChargingCurrent", + "type": "uint", + "unit": "Ampere", + "minValue": 6, + "maxValue": 16 } ] } From 49a03580bee7ebe433bd108083697be867777925 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Fri, 22 Oct 2021 12:08:48 +0200 Subject: [PATCH 2/3] Make minimal charging current writable --- libnymea/interfaces/electricvehicle.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libnymea/interfaces/electricvehicle.json b/libnymea/interfaces/electricvehicle.json index d5cbcaa6..68ac762e 100644 --- a/libnymea/interfaces/electricvehicle.json +++ b/libnymea/interfaces/electricvehicle.json @@ -12,7 +12,8 @@ "type": "uint", "unit": "Ampere", "minValue": 6, - "maxValue": 16 + "maxValue": 16, + "writable": true } ] } From 442f33e50d034becd988d8143900a935f2a6fd4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Wed, 27 Oct 2021 17:34:34 +0200 Subject: [PATCH 3/3] Allign minimal charging current to system naming --- libnymea/interfaces/electricvehicle.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libnymea/interfaces/electricvehicle.json b/libnymea/interfaces/electricvehicle.json index 68ac762e..114a8281 100644 --- a/libnymea/interfaces/electricvehicle.json +++ b/libnymea/interfaces/electricvehicle.json @@ -1,5 +1,5 @@ { - "description": "Interface for electric vehicles. Some electric cars require a minimal charging current, otherwise they don't start charging. Default is a minimum of 6 ampere.", + "description": "Interface for electric vehicles. Some electric cars require a minimum charging current, otherwise they don't start charging. Default is a minimum of 6 ampere.", "extends": ["battery"], "states": [ { @@ -8,12 +8,12 @@ "unit": "KiloWattHour" }, { - "name": "minimalChargingCurrent", + "name": "minChargingCurrent", "type": "uint", "unit": "Ampere", "minValue": 6, "maxValue": 16, - "writable": true + "optional": true } ] }