ETM-Schurig/powersync-app
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

MAke energy logs more robust against faulty databases

Browse Source
This commit is contained in:
Michael Zanetti 2022-12-22 14:45:31 +01:00
parent d6bceea1a9
commit 4e557e20b8
1 changed files with 20 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
libnymea-app/energy/energylogs.cpp
View File

@ -193,10 +193,10 @@ int EnergyLogs::indexOf(const QDateTime &timestamp)
int index = qRound(1.0 * first.secsTo(timestamp) / (m_sampleRate * 60)); int index = qRound(1.0 * first.secsTo(timestamp) / (m_sampleRate * 60));
if (index < 0 || index >= m_list.count()) { if (index < 0 || index >= m_list.count()) {
// qWarning() << "finding:" << timestamp << index << first.toString() << "NOT FOUND" << m_list.last()->timestamp(); qCDebug(dcEnergyLogs()) << "finding:" << timestamp << index << first.toString() << "NOT FOUND" << m_list.last()->timestamp() << m_list.count();
return -1; return -1;
} }
// qWarning() << "finding:" << timestamp << index << first.toString() << m_list.at(index)->timestamp(); qCDebug(dcEnergyLogs()) << "finding:" << timestamp << index << first.toString() << m_list.at(index)->timestamp();
// Normally, if the DB is in a consistent state, we can rely that the above finds the correct entry. // Normally, if the DB is in a consistent state, we can rely that the above finds the correct entry.
@ -282,7 +282,7 @@ void EnergyLogs::getLogsResponse(int commandId, const QVariantMap &params)
Q_UNUSED(commandId) Q_UNUSED(commandId)
double minValue = 0, maxValue = 0; double minValue = 0, maxValue = 0;
// qCDebug(dcEnergyLogs()) << "Logs response:" << qUtf8Printable(QJsonDocument::fromVariant(params).toJson()); qCDebug(dcEnergyLogs()) << "Logs response:" << qUtf8Printable(QJsonDocument::fromVariant(params).toJson());
QList<EnergyLogEntry*> entries = unpackEntries(params, &minValue, &maxValue); QList<EnergyLogEntry*> entries = unpackEntries(params, &minValue, &maxValue);
if (!entries.isEmpty()) { if (!entries.isEmpty()) {
@ -314,16 +314,24 @@ void EnergyLogs::getLogsResponse(int commandId, const QVariantMap &params)
} }
} else { } else {
// End of fetched entries does not line up with start of existing entries. Discarding existing entries // End of fetched entries does not line up with start of existing entries. Discarding existing entries
qCDebug(dcEnergyLogs()) << "End of fetched entries does not line up with start of existing entries. Discarding existing entries" << entries.last()->timestamp().addSecs(m_sampleRate * 60).toString() << " - " << m_list.first()->timestamp().toString(); qCDebug(dcEnergyLogs()) << "End of fetched entrie does not line up with start of existing entries. Discarding existing entries" << entries.last()->timestamp().addSecs(m_sampleRate * 60).toString() << " - " << m_list.first()->timestamp().toString();
clear(); clear();
beginInsertRows(QModelIndex(), 0, entries.count());
m_list.append(entries); // If the mismatch is in the visible area, we'll discard everything and fetch again
endInsertRows(); // Else if the mismatch is outside the visible area, we'll just discard the old data and work with what we received
emit entriesAdded(0, entries); if (entries.first()->timestamp() <= m_startTime && entries.last()->timestamp() >= m_endTime) {
m_minValue = minValue; beginInsertRows(QModelIndex(), 0, entries.count());
emit minValueChanged(); m_list.append(entries);
m_maxValue = maxValue; endInsertRows();
emit maxValueChanged(); emit entriesAdded(0, entries);
m_minValue = minValue;
emit minValueChanged();
m_maxValue = maxValue;
emit maxValueChanged();
} else {
qDeleteAll(entries);
fetchLogs();
}
} }
} else if (entries.first()->timestamp().addSecs(-m_sampleRate * 60) == m_list.last()->timestamp()) { } else if (entries.first()->timestamp().addSecs(-m_sampleRate * 60) == m_list.last()->timestamp()) {