From a44b82c497e284f1ad1e6add3cbcbd5a2dcff43a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20St=C3=BCrz?= Date: Tue, 19 Feb 2019 16:12:14 +0100 Subject: [PATCH] Fix push button auth finished notification API documentation --- libnymea-core/jsonrpc/jsonrpcserver.cpp | 2 +- nymea.pri | 2 +- tests/auto/api.json | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libnymea-core/jsonrpc/jsonrpcserver.cpp b/libnymea-core/jsonrpc/jsonrpcserver.cpp index 76451abc..4ee131c7 100644 --- a/libnymea-core/jsonrpc/jsonrpcserver.cpp +++ b/libnymea-core/jsonrpc/jsonrpcserver.cpp @@ -208,7 +208,7 @@ JsonRPCServer::JsonRPCServer(const QSslConfiguration &sslConfiguration, QObject params.clear(); setDescription("PushButtonAuthFinished", "Emitted when a push button authentication reaches final state. NOTE: This notification is special. It will only be emitted to connections that did actively request a push button authentication, but also it will be emitted regardless of the notification settings. "); - params.insert("status", JsonTypes::userErrorRef()); + params.insert("success", JsonTypes::basicTypeToString(JsonTypes::Bool)); params.insert("transactionId", JsonTypes::basicTypeToString(JsonTypes::Int)); params.insert("o:token", JsonTypes::basicTypeToString(JsonTypes::String)); setParams("PushButtonAuthFinished", params); diff --git a/nymea.pri b/nymea.pri index 1d8c9692..0aba4324 100644 --- a/nymea.pri +++ b/nymea.pri @@ -6,7 +6,7 @@ NYMEA_PLUGINS_PATH=/usr/lib/$$system('dpkg-architecture -q DEB_HOST_MULTIARCH')/ # define protocol versions JSON_PROTOCOL_VERSION_MAJOR=1 -JSON_PROTOCOL_VERSION_MINOR=12 +JSON_PROTOCOL_VERSION_MINOR=13 REST_API_VERSION=1 DEFINES += NYMEA_VERSION_STRING=\\\"$${NYMEA_VERSION_STRING}\\\" \ diff --git a/tests/auto/api.json b/tests/auto/api.json index 08cac836..3dd4a45f 100644 --- a/tests/auto/api.json +++ b/tests/auto/api.json @@ -1030,7 +1030,7 @@ "description": "Emitted when a push button authentication reaches final state. NOTE: This notification is special. It will only be emitted to connections that did actively request a push button authentication, but also it will be emitted regardless of the notification settings. ", "params": { "o:token": "String", - "status": "$ref:UserError", + "success": "Bool", "transactionId": "Int" } },