From 1ba818c69fe4c6629a0e57a09249939336892566 Mon Sep 17 00:00:00 2001 From: "bernhard.trinnes" Date: Tue, 24 Mar 2020 14:33:51 +0100 Subject: [PATCH] changes requested by reviewer --- aqi/README.md | 2 +- aqi/integrationpluginaqi.cpp | 10 ++-------- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/aqi/README.md b/aqi/README.md index 2af6239c..6e18d23f 100644 --- a/aqi/README.md +++ b/aqi/README.md @@ -34,7 +34,7 @@ inform you what precautions should be taken. * Valid "Air Quality Index" API Key * The package "nymea-plugin-airqualityindex" must be installed -* Intenet connection +* Internet connection ## More diff --git a/aqi/integrationpluginaqi.cpp b/aqi/integrationpluginaqi.cpp index 29887096..99225f32 100644 --- a/aqi/integrationpluginaqi.cpp +++ b/aqi/integrationpluginaqi.cpp @@ -88,6 +88,7 @@ void IntegrationPluginAqi::discoverThings(ThingDiscoveryInfo *info) } QUuid requestId = m_aqiConnection->getDataByIp(); m_asyncDiscovery.insert(requestId, info); + connect(info, &ThingDiscoveryInfo::aborted, [=] {m_asyncDiscovery.remove(requestId);}); } void IntegrationPluginAqi::setupThing(ThingSetupInfo *info) @@ -123,8 +124,6 @@ void IntegrationPluginAqi::setupThing(ThingSetupInfo *info) } } - - void IntegrationPluginAqi::postSetupThing(Thing *thing) { if (thing->thingClassId() == airQualityIndexThingClassId) { @@ -144,13 +143,9 @@ void IntegrationPluginAqi::postSetupThing(Thing *thing) } } - void IntegrationPluginAqi::thingRemoved(Thing *thing) { - if (thing->thingClassId() == airQualityIndexThingClassId) { - - } - + Q_UNUSED(thing) if (myThings().empty()) { if (!m_pluginTimer) { hardwareManager()->pluginTimerManager()->unregisterTimer(m_pluginTimer); @@ -163,7 +158,6 @@ void IntegrationPluginAqi::thingRemoved(Thing *thing) } } - void IntegrationPluginAqi::onAirQualityDataReceived(QUuid requestId, AirQualityIndex::AirQualityData data) { if (m_asyncSetups.contains(requestId)) {